Implemented the completion suggester for auto-complete functionality #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Awesome++ this is a pretty big feature PR. Many many thanks @gmarz looking forward to pulling it in 👍 |
Contributor
Author
|
Great. There are a few TODOs, namely:
I'll get around to completing those, but I think this is a pretty functional first pass. |
Member
|
thanks for the update, you can leave out the attribute based mapping, it will be phased out and only used for the quick wins if you will, forcing a property name or declaring which property is the Is. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/search-suggesters-completion.html
As the documentation states, this is currently an experimental feature of Elasticsearch, but it works pretty well and it completes the suggestion offering of NEST (as we already have the Term and Phrase suggesters).