-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate Docker Containers? #22
Comments
Hi, At the moment I don't know how I would build a single image for the services, the web, api and worker should most likely be easiest to consolidate into one container. I will have to look into this further. |
At least for the auth perspective, it might be worth planning long-term support for those homelab-ers that already have an authentication solution (i.e. authentik or authelia). This would remove one docker container from the things to manage. My naive two cents :D |
Thank you @McMumf for your input! I am not 100% sure how authentik or similar solutions would work to remove the need for the auth container. The API backend authenticates based on JWT tokens, I will still have to somehow issue tokens based on authentication against simple email/password or oauth endpoints. However I am not familiar with authentik or similar solutions and will have to look into them further and not dismiss them as "only" a oauth provider. What I think I will do for now is rewrite the auth-server into a flask extension. This would remove the need for a separate container while still providing the same use case, mainly being not having to write authentication code for every single project I write and having copy-pasted code all over the place. I believe this would be a simple change. |
Hi,
Given the number of separate docker containers, it is quite daunting to deploy booklogr (I myself am holding out for now) - It might be a good idea to consolidate the docker containers into a more manageable number (ideally 2 maybe 3).
Thanks!
The text was updated successfully, but these errors were encountered: