-
Notifications
You must be signed in to change notification settings - Fork 220
FxR controller and display names should match the native browser's names. #401
Comments
Good catch. Removing
I understand that the main reason for the If there's not already enough information with the current properties, a dictionary of capabilities (per w3c/gamepad#12) could be added so developers don't need to sniff for the name. |
Actually we have already set different names for each display, so it should report different names on each. But yep, it's good to check we are using names that apps are checking correctly. For the controllers we set the ones used in AFrame (e.g "Gear VR Remote Controller") |
@larsbergstrom and I will figure out webcompat loop. |
Whichever we choose, we should make sure they are supported by those defined in this popular library used with three.js: https://github.com/stewdio/THREE.VRController/blob/master/VRController.js. (And obviously make PRs when appropriate.) Oculus Go Controller has been recently added, FYI. |
I've commented on w3c/gamepad#73 (comment). Will update as I do some research on the actual sites possibly impacted by |
Closing as resolved. |
Hardware
All
Current Behavior
We use the same names on all platforms and do not match any existing platforms.
Possible Solution
We should examine what names are used in each native browser and emulate them. A lot of code is already sniffing for specific platform names and it would be easier to just emulate than try and get existing websites to update their code to look for FxR specific strings.
Context
The FxR controller doesn't work on sketchfab.com because they are looking for specific controller names in their code.
The text was updated successfully, but these errors were encountered: