Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public CDN support #434

Closed
tobias-kuendig opened this issue Feb 17, 2016 · 5 comments
Closed

Public CDN support #434

tobias-kuendig opened this issue Feb 17, 2016 · 5 comments

Comments

@tobias-kuendig
Copy link

It would be great to be able to include the keyboard from a public cdn like cdnjs.com

See https://github.com/cdnjs/cdnjs/blob/master/CONTRIBUTING.md#d-adding-a-new-library

Is there any support planned?

@Mottie
Copy link
Owner

Mottie commented Feb 17, 2016

Hi @tobias-kuendig!

Well, I started trying to add this repo to cdnjs...

  • The npm auto update code was added to the package.json (ref).
  • I forgot how unwieldy it was to deal with the size of cdnjs, but I discovered use of a sparse checkout and shallow clone - the repo still ended up being about 1GB in size.
  • Then I discovered the documentation was missing the "filename" requirement for autoupdate because I couldn't get my tests to pass.
  • So I opened a PR: Add missing "filename" requirement for autoupdate cdnjs/cdnjs#6765, and started waiting for that to get merged before adding this repo because it would be added to that PR since cdnjs doesn't appear to use branches.
  • Then I forgot about it 😁

So, maybe it would be easier to request they add it.

@Mottie
Copy link
Owner

Mottie commented Feb 17, 2016

Actually, the issue is that I couldn't get npm test to pass...

see cdnjs/cdnjs#4961 (comment)

@Mottie
Copy link
Owner

Mottie commented Feb 17, 2016

Ok... see cdnjs/cdnjs#7010!

@Mottie
Copy link
Owner

Mottie commented Feb 18, 2016

Done! https://cdnjs.com/libraries/virtual-keyboard

Thanks again!

@Mottie Mottie closed this as completed Feb 18, 2016
@tobias-kuendig
Copy link
Author

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants