Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close not being triggered #199

Closed
cmeadie opened this issue Aug 20, 2013 · 8 comments
Closed

Close not being triggered #199

cmeadie opened this issue Aug 20, 2013 · 8 comments
Labels

Comments

@cmeadie
Copy link

cmeadie commented Aug 20, 2013

I have a form with multiple text inputs and I'm binding a different keyboard to each input since some are numbers and others are email addresses, etc...

I've noticed that if I have a keyboard open for one input and I click a different input that has a bound keyboard, the 'beforeClose' callback is not triggered for that specific instance of the keyboard. I've tracked this back to the 'escClose' function not firing.

What is more bizarre is that it seems to work properly for the first keyboard/input I bind, but all others it does not.

Clicking non keyboard bound inputs or anywhere else on the page seems to behave as expected.

I'll probably just build a workaround for my current project, but I thought I should at least report the issue.

The keyboard is great though, keep up the good work.

@cmeadie
Copy link
Author

cmeadie commented Aug 30, 2013

I may have more information, It looks like if you have a keyboard open and you click another input with a bound keyboard, they opening reveal sequence is somehow preventing the hiding sequence from fully processing or perhaps processing at all.

@Mottie
Copy link
Owner

Mottie commented Oct 7, 2013

HI @cmeadie!

Would you by chance be using IE when noticing these problems? Which browser version? If not, which browser? and which keyboard plugin version?

@cmeadie
Copy link
Author

cmeadie commented Oct 7, 2013

Actually I was running Firefox 21.0 and replicated the issue in Google Chrome 29.0.154766.
Since the environment it runs in will be controlled I shouldn't have to patch it for IE.

The keyboard version is 1.17.7
Jquery is at version 1.9.1
Jquery-ui is version 1.10.3

@Mottie
Copy link
Owner

Mottie commented Oct 7, 2013

Oh! Derp... I completely misread the issue you are having... yes I see the problem now. I'll have it fixed really soon :P

@Mottie
Copy link
Owner

Mottie commented Oct 7, 2013

Hmm, okay, maybe not "really" soon... it's a bit more complicated than I thought and I might just wait to fix this problem when I get around to rewriting the plugin. Hopefully, that will be soon.

@cmeadie
Copy link
Author

cmeadie commented Oct 7, 2013

Yeah, I tried seeing if I could fix it myself, but my experience with the internals of jQuery plug-ins is rudimentary at best.

I built an external work around for the callbacks where i stuff the callback in a variable and trigger it by stuffing in a new callback. An empty function is stuffed in if the keyboard closes naturally.

This only visibly leaves the issue of the keyboard not displaying if a keyboard is showing, then the user clicks another keyboard bound input, and then I programmatically focus on the original input. If they click the input the keyboard pops up.

Hopefully this rarely occurs and waiting for a rewrite should not be an issue.

Great plug-in though. Thanks.

@Mottie
Copy link
Owner

Mottie commented Oct 7, 2013

Ugh, never mind LOL... after thinking about this, I think it's a critical issue... so, now I think I've finally got it fixed. I wish I had some unit testing put together to make sure I didn't break anything else, but that's just more work that I don't have time for right now :(

@Mottie Mottie closed this as completed in b4a3c48 Oct 7, 2013
@cmeadie
Copy link
Author

cmeadie commented Oct 7, 2013

Looks good, I integrated it the new script into my project and it works great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants