Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GitHub Collapse Markdown) fix for no longer working in Greasemonkey #13

Closed
darkred opened this issue Oct 3, 2016 · 2 comments
Closed
Labels

Comments

@darkred
Copy link
Collaborator

darkred commented Oct 3, 2016

The following is a Firefox/Greasemonkey-only issue:
in Chrome 53/Tampermonkey 4.1.10 the issue doesn't occur.

Using GCM v1.1.3 with GM 3.9 in FF 49 (win 10 x64).

The script was no longer collapsing Markdown in any GitHub page.
To make sure I tried in a fresh FF profile with only GM installed and the script
and opened as a reference https://github.com/sinatra/sinatra
(i.e. is the page that you used in the screen capture) :
no content was collapsed.

I was getting

missing = in const declaration                 GitHub_Collapse_Markdown.user.js:233:13

in Browser Console.

So, changing lines 233 and 240
from
for (const el of els) {
to
for (let el of els) {
fixes the issue.

@Mottie
Copy link
Owner

Mottie commented Oct 3, 2016

Hi @darkred!

Thanks for letting me know! I'll have it fixed in a minute!

Also, in case you didn't know, I'll be going out of town for the next month starting tomorrow. So if you don't get a response from me, you'll know why.

@Mottie Mottie added the bug label Oct 3, 2016
@Mottie Mottie closed this as completed in e820b3f Oct 3, 2016
@darkred
Copy link
Collaborator Author

darkred commented Oct 4, 2016

You're welcome.
And thanks for letting me know, I really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants