Skip to content

Add option to not remove FlowAsset instances on flow finished #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reisandbeans opened this issue Nov 4, 2024 · 1 comment
Closed
Assignees
Labels
improvement Polishing existing functionality

Comments

@reisandbeans
Copy link

The bRemoveInstance option from UFlowAsset::FinishFlow doesn't seem to be used by any of the callers, meaning that in all paths that eventually call FinishFlow, the instance will be removed. For some use cases, I'd like it not to be removed (for example in a Dialog flow, where the same NPC will go over and over the same nodes for as long as the player keeps talking to them), but instead reuse the existing instance.

Once suggestion would be to propagate this flag on some of the paths where this function is called, such as FlowNode_Finish.cpp so we could optionally prevent the instance from being removed.

@MothDoctor let me know if this is something you would be ok with and I can perhaps send a PR implementing these changes

@MothDoctor MothDoctor self-assigned this Nov 6, 2024
@MothDoctor MothDoctor added the improvement Polishing existing functionality label Dec 15, 2024
@MothDoctor
Copy link
Contributor

@reisandbeans Totally, I would be open to accepting such change.
bRemoveInstance has been added for similar purposes as yours, although my case didn't need to propagate this flag further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Polishing existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants