Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling default regexp #19

Closed
jacob-keller opened this issue Feb 6, 2017 · 7 comments
Closed

allow disabling default regexp #19

jacob-keller opened this issue Feb 6, 2017 · 7 comments

Comments

@jacob-keller
Copy link
Contributor

Is it possible to disable the default search parameters? I don't really need number searching, and I don't really find the path searching that useful since it gets a lot of false positives. Thus, these hints clutter the display making it harder to locate the things I want to copy.

@Morantron
Copy link
Owner

In the current version is not possible to disable default patterns, but that's a good point.

It could be fixed by conditionally adding patterns to the PATTERN_LIST array here.

To enable this, a new variable @fingers-enabled-default-patterns could be set to comma separated names of patterns. ex: shas,digits,ips

PR welcome! \o/

@aspiers
Copy link

aspiers commented Jul 5, 2022

I agree that this would be a useful modification. Also even without disabling default patterns, I think the user ones should take precedence. Currently it seems they are matched after the built-ins.

@quite
Copy link

quite commented Aug 4, 2022

@Morantron sounds like you'd then have to give clear, understandable names to the default patterns? Might be tricky to do it well. We could go for adding just a way to disable the default patterns? Since the user anyway is about to customize their own... Like @fingers-disable-default-patterns with values 0 (default) or 1. I could prepare a PR with that.

@Morantron
Copy link
Owner

@Morantron sounds like you'd then have to give clear, understandable names to the default patterns? Might be tricky to do it well. We could go for adding just a way to disable the default patterns? Since the user anyway is about to customize their own... Like @fingers-disable-default-patterns with values 0 (default) or 1. I could prepare a PR with that.

You are right 🤔

Regarding the PR, I'm rewriting the whole thing in ruby. Just need to get my ass to document the changes and release it once and for all.

@quite
Copy link

quite commented Aug 5, 2022

Oh, that's somewhat unfortunate for me personally. Bash and gawk is O-K, but I'd not depend on having ruby on my systems for this kind of basic working-environment stuff. I'd have to remain on tmux-fingers in bash. Hohum.

@Morantron
Copy link
Owner

¯\_(ツ)_/¯

@Morantron
Copy link
Owner

Fixed in 2.2.0 (seven years later hehehehehe). Check out this new option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants