fix: 🐛 change update_x_payment_stream functions to not error out if user is insolvent
#273
+209
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user is insolvent
snowmead
reviewed
Nov 27, 2024
| @@ -7393,6 +7242,149 @@ mod delete_file_and_pending_deletions_tests { | |||
| ); | |||
| }); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn delete_file_expired_pending_file_deletion_request_with_insolvent_user() { | |||
There was a problem hiding this comment.
Thanks! It's just the previous test with some changes hehe
| ); | ||
|
|
||
| // Assert that the payment stream was correctly deleted since the user is without funds | ||
| assert!(pallet_payment_streams::FixedRatePaymentStreams::<Test>::get(msp_id, owner_account_id.clone()).is_none()); |
There was a problem hiding this comment.
how did the payment stream get automatically deleted?
There was a problem hiding this comment.
The idea is that when a provider tries to charge a user that is deemed as without funds, the manage_user_without_funds logic gets executed, which basically charges the debt of the payment stream from the user deposit and then clears it. After this, the provider is free to delete without penalty any files from the user since the runtime knows that it is not getting paid for them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic of updating payment streams. Now, instead of erroring out when the user of the payment stream is insolvent, we charge the payment stream and since the function that does that already manages insolvent users, the payment stream would get charged for its debt and deleted.