Multi-platform builds using GitHub workflows #70
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request implements
docker buildx
to create multi-platform builds of themonogramm/docker-dolibarr
image.The general structure of this branch has been replicated in https://github.com/maksimstojkovic/docker-dolibarr-arm, which has successfully pushed a multi-platform image to
maksimstojkovic/dolibarr
. This image has been tested on a Raspberry Pi 4 running 64-bit Ubuntu 20.04 LTS and is functional.An effort has been made to ensure all variables are consistent with the current
monogramm/docker-dolibarr
GitHub and DockerHub naming schemes. QEMU and docker buildx have been added to the GitHub workflow for building and testing. An additional manual workflow was created to demonstrate how multi-platform images can be pushed to DockerHub.All major changes were added to the first commit. The second commit contains updates to images, which were generated by running
./update.sh
. The second commit also executed the equivalent ofchmod +x
on hook scripts within the repo.The purpose of implementing these changes is to allow devices running
armhf
andarm64
, such as the Raspberry Pi 3 and Raspberry Pi 4, respectively, to run themonogramm/docker-dolibarr
image.Merging proposed changes should not have any impact on the performance of existing
amd64
containers. Instead, it aims to extend current functionality to allow devices using different platforms to pull from the same image tag.closes #54
N/A
I'm happy to answer any questions about changes I've made.