Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monofoxe Credit #4

Closed
Martenfur opened this issue Oct 27, 2024 · 3 comments
Closed

Monofoxe Credit #4

Martenfur opened this issue Oct 27, 2024 · 3 comments

Comments

@Martenfur
Copy link

Just a suggestion, instead of doing an off-brand Monofoxe, you could just contribute to the real thing. ;)

Also at the very least mention that you've based this on Monofoxe, like, for real.

@BlizzCrafter
Copy link
Member

Hey @Martenfur!

Nice that you found your way to this project. I really like your foundational work of the Monofoxe engine and wanted to build upon that. I noticed that what I had in mind for my own abstraction of your engine would be fundamentally different from yours, so I decided to start my own project. I also plan to remove some core elements of Monofoxe mid-therm and I am pretty sure that this is not in your interest.

The Readme of your Monofoxe engine sais:

"Monofoxe is licensed under MIT, so you can use it and its code in any shenanigans you want. Free games, commercial games, your own the-coolest-in-the-world engines - no payment or royalties required."

And:

"Just please leave a credit. ; - )"

What I did in the License.txt file of my project if you look closely.

I even have a "monofoxe" tag in the upper right repo description.

Reading the Readme file of your project, I thought I credited you in the right way. Please let my know if you want to be credited in a different way and I will of course do that.


"you could just contribute to the real thing."

But... I did...: Martenfur/Monofoxe#26

Btw: Are you still working activley on Monofoxe? It seemed to be on halt for a while.

Cheers!

@BlizzCrafter BlizzCrafter changed the title boo Monofoxe Credit Oct 27, 2024
@Martenfur
Copy link
Author

No, no, I'm not saying you can't do that, of course you can, I wouldn't have FOSSed it otherwise. Just you know, the usual practice is to put a reference like "based on Monofoxe" in readme - you know, where people will actually see it, nobody reads licenses or looks at tags, including me. :D

Aaaand yes, I took a quick glance at the code and there are a lot of weird decisions and things that will come to haunt you later down the line. Like separating samples into a its own repo, it'll just cause you unnecessary headaches since now you can't just launch samples off of your develop branch without compiling nugets first and linking them locally.

Current state of Monofoxe is in support. I am currently mainly developing a game and trickling down features and integrations from it to the main engine. I have a lot of semi-completed modules like UI, physics, skeleton animations and other things that aren't quite ready but will be brought into Monofoxe at some point. That's why I'm offering to work on the main thing, so that we don't do double amount of work implementing the same stuff.

@BlizzCrafter
Copy link
Member

Okay, I agree on that. Thats why I just added a "Credits" section via 7d11e34

Here:
https://github.com/MonoGo-Engine/MonoGo?tab=readme-ov-file#credits


can't just launch samples off of your develop branch without compiling nugets first and linking them locally.

Yeah, first I don't wanted to do that neither. But now I have a local setup which works. It is just a seperate .sln file which hooks up the samples project and references the engine libs instead of nugets and such. I will see how long that lasts :)

Current state of Monofoxe is in support.

Ah, thanks for letting me know. I will surly stop by from time to time and see how your engine evolves. Of course I would contribute again if I see something fit in.

Thanks for creating Monofoxe and keep going!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants