Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash Report #38

Closed
robogena opened this issue Feb 20, 2024 · 5 comments
Closed

Crash Report #38

robogena opened this issue Feb 20, 2024 · 5 comments

Comments

@robogena
Copy link

robogena commented Feb 20, 2024

Hi Cherry! 👋 Just got a random mod loader crash so I'm sending the report your way. I've never had the watcher crash before so I'm not sure what happened... only thing I've been doing differently is launching the game directly from the exe (so I can avoid hotfix 18 for awhile, lol) and it was otherwise working fine all day.

The watcher crashed immediately on game load and then again when I tried to quit it from the toolbar. Ended the task, restarted the watcher, reloaded the game and now it works perfectly fine, so... ????? ¯_(ツ)_/¯

YABG3ML Version: Watcher, v0.2.2
Game Version: BG3 DX11, Patch 6, v4.1.1.4763283

If there's other logs or info that you might need, just let me know!

crashreport.zip

@MolotovCherry
Copy link
Owner

MolotovCherry commented Feb 20, 2024

Thank you for your crash report!

If possible, could you try to reproduce it and give me some reproducible steps?

When you're trying to reproduce it, you can open a terminal to the location of the watcher executable and run the following. This will produce a detailed trace log of everything so I can see everything more clearly

(note, this is assuming you're in a powershell terminal)

$env:YABG3ML_LOG="trace"
./bg3_watcher.exe --cli > log_output.txt

There may be some private path information in here, so if you're worried about privacy, you may scrub private info from the log first

@MolotovCherry
Copy link
Owner

MolotovCherry commented Feb 20, 2024

While I'm at it, I addressed the line in your log.

A new build is building with the line fixed. Once it finishes, there will be a section that says "Artifacts" (see image below), click the "build" link to download the test build. Can you try to get this version to crash for me?
https://github.com/MolotovCherry/Yet-Another-BG3-Native-Mod-Loader/actions/runs/7981227066

I'm fairly confident the crash on load is now fixed in 85fd172, and as for the crash when quitting, that one is benign (it's a result of the first one). Edit: Fixed the crash while stopping too

image

@robogena
Copy link
Author

Oh god, I'm so powershell illiterate so I don't know if I did this right. I'm trying the debug build and now the watcher exe creates a blank terminal window. Am I supposed to see something there? The exe does work fine though. I was able to generate the log_output at least!

The only thing I could think that I did differently was that I'm in the middle of updating armor stats in a pak, and I think I didn't re-export my mod list prior to launching, like I usually do. I tried to recreate that on both the v0.2.2 and debug watcher builds, but no crash. I have no idea what I did to crash it!

log_output.txt

@MolotovCherry
Copy link
Owner

MolotovCherry commented Feb 20, 2024

Oh god, I'm so powershell illiterate so I don't know if I did this right. I'm trying the debug build and now the watcher exe creates a blank terminal window. Am I supposed to see something there? The exe does work fine though. I was able to generate the log_output at least!

It's alright! I'm very certain the crash is completely fixed now anyways, so you don't need to bother with these steps or with trying to reproduce it. I had enough info from the log to figure it out.

But to answer the questions

Am I supposed to see something there?

If you did the > log_output.txt, then it's normal to see no output, yes! (The output was redirected into the file instead)

Thanks again for your crash report! I'll release a new version shortly after I'm done with a few maintenance things.

@robogena
Copy link
Author

Thank YOU for the speedy fix!! Looking forward to the new version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants