-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to specify "classPrefix" option #20
Comments
+1 for this. I think this is a crucial feature |
This is a problem with the customizr dependency |
@doctyper The fix on customizr is now merged, could then the functionality be propagated to gulp-modernizr? |
Ping @doctyper |
Thanks, I changed my previous message! |
@doctyper This is actually still broken in customizr master but there is a fix in dev which isn't merged. Nothing has to change in this package for the fix to propagate other than updating customizr. Modernizr/customizr#20 |
Quick fix until customizr team cuts a release:
|
@typeoneerror with this quick fix, how does one enable gulp-modernizr to work with it instead of its own customizr? just installing seems obviously not enough. |
@certainlyakey that should install the develop branch locally so it should automatically use it. this line here should find whichever customizr version you have installed. https://github.com/doctyper/gulp-modernizr/blob/develop/index.js#L4 |
@typeoneerror hmm it did not find it however. Maybe I should I reinstall gulp-modernizr so it could find the separate customizr package on installing... |
Seems like, if you specify the For example, when using |
hi @ALL
you should be able to specify a class prefix like 'foo' for example and have it a class called 'fooflexbox' be recognized too. Please test it out and report any bugs of course. |
Interesting. What config are you using gulp-modernizr with? |
Here's the gulpfile task:
where I also tried to remove uglify but this doesn't produce any change. |
This will be fixed in the next release of (gulp-)modernizr. |
Add ability to specify
classPrefix
option for crawler and builder.The text was updated successfully, but these errors were encountered: