Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: media background thumbnail modes [stretch, fit or fill] #361

Closed
amrbashir opened this issue Jan 15, 2021 · 4 comments · Fixed by #369
Closed

Feature Request: media background thumbnail modes [stretch, fit or fill] #361

amrbashir opened this issue Jan 15, 2021 · 4 comments · Fixed by #369
Assignees
Labels
Enhancement New feature or request Fixed Has been fixed. Good First Issue Good for newcomers

Comments

@amrbashir
Copy link

amrbashir commented Jan 15, 2021

Is your feature request related to a problem? Please describe:

The background thumbnail is not consistent, some thumbnails are big which covers the whole flyout but others don't which irritates me to be honest (symmertical ocd).

Describe the solution you'd like:

A new dropdown menu option where I can select one of three modes, stretch, fill, or fit.

Love your app though and appreciate your work.

@amrbashir amrbashir changed the title Feature Request: media thumbnail center alignment Feature Request: media background thumbnail modes [stretch, fit or fill] Jan 15, 2021
@ShankarBUS
Copy link
Member

Whaaaaaaaaaaaat?

I don't understand what you're trying to say properly.

Could you explain a bit clearly?

Are you talking about the thumbnail shown in the background?

Could you post some screenshots?

@amrbashir
Copy link
Author

amrbashir commented Jan 15, 2021

Yes, the thumbnail in the background and also the mini thumbnail.

This one doesn't fill the whole flyout.

image

This one does.

image

That kinda irritates me but beyond that a different modes to enforce the thumbnail to either fit, fill or stretch can be a good addition.
kinda like Windows 10 Background fit options.

image

@ShankarBUS
Copy link
Member

Ah Spotify!

This issue can't be fixed by providing an option to change the stretch mode.

This is a problem intentionally created by Spotify!
Look at this image, this is what they provide us as the thumbnail.

But you're in good hands! We fixed this issue by specifically cropping Spotify's thumbnails.

Hope that helps 🙂.

@amrbashir
Copy link
Author

Yeah that's good enough for me. Again sorry for the inconvenience. keep up the good work.

@ShankarBUS ShankarBUS added Enhancement New feature or request Fixed Has been fixed. Good First Issue Good for newcomers labels Jan 18, 2021
@ShankarBUS ShankarBUS mentioned this issue Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Fixed Has been fixed. Good First Issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants