Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary manifest_typings.json entry for embedded:network/* causes warning #1365

Closed
cmidgley opened this issue Jul 6, 2024 · 1 comment

Comments

@cmidgley
Copy link
Contributor

cmidgley commented Jul 6, 2024

Build environment: Windows (problem likely occurs on all)
Moddable SDK version: Latest released as of today (any within last six months)
Target device: Win, ESP32

Description
When compiling TypeScript and using examples/manifest_typings.json you get a warning on each build:

# warning: no modules match: c:\moddable\typings\embedded_network\*!

This is because six months ago a change was made that added:

"embedded:network/*": [
	"$(TYPINGS)/embedded_network/*"
]

However, no type files are located at that location (they are all in sub-directories and specifically included in the typings).

Removing this line from examples/manifest_typings.json continues to compile TypeScript but without the warning message.

Steps to Reproduce

  1. Set up a TypeScript app that has a manifest.json that includes:
	"include": [
		"$(MODDABLE)/examples/manifest_typings.json",
	],
  1. Compile with mcconfig
  2. See warning in first line output
@cmidgley
Copy link
Contributor Author

Fix proposed as part of #1429. Closing as it’s not a big deal and we can discuss if necessary there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant