Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flex features to list #1776

Closed
emmambd opened this issue May 30, 2024 · 4 comments · Fixed by #1780
Closed

Add Flex features to list #1776

emmambd opened this issue May 30, 2024 · 4 comments · Fixed by #1780
Assignees
Labels
enhancement New feature request or improvement on an existing feature

Comments

@emmambd
Copy link
Contributor

emmambd commented May 30, 2024

Describe the problem

Now that Flex is adopted, we want to be able to track usage of Flex features within the validator and within the Mobility Database API, which includes features generated by the GTFS Schedule Validator.

Proposed solution

The following four features should be added:

Booking Rules: At least one record in booking_rules.txt
Fixed-Stops Demand Responsive Transit: At least one record in location_groups.txt
Zone-based Demand Responsive Transit: At least a trip in stop_times references only location_id
Deviated Fixed Route: At least a trip in stop_times references location_id AND stop_id AND arrival_time AND departure_time

Alternatives you've considered

No response

Additional context

No response

@emmambd emmambd added enhancement New feature request or improvement on an existing feature status: Needs triage Applied to all new issues labels May 30, 2024
@emmambd
Copy link
Contributor Author

emmambd commented May 30, 2024

cc @Sergiodero @tzujenchanmbd

@emmambd emmambd added this to the 6.0 Validator Release milestone May 30, 2024
@tzujenchanmbd
Copy link

I'd like to modify Deviated Fixed Route a bit:
At least a trip in stop_times references location_id AND stop_id AND arrival_time AND departure_time

@qcdyx
Copy link
Contributor

qcdyx commented Jun 6, 2024

@emmambd Could you elaborate on the definition of Zone-based Demand Responsive Transit?

In the first screenshot, each trip_id corresponds to a location_id. Is this a valid example? (I believe yes)
What might constitute an invalid example?
image
Is the second screenshot an invalid Zone-based Demand Responsive Transit? (yes, since it contains a_valid_stop_id)
image

@emmambd
Copy link
Contributor Author

emmambd commented Jun 6, 2024

@qcdyx You're correct - Zone-based Demand Responsive Transit should be triggered when there is a location_id associated with a trip_id. It should not be triggered when stop_id is associated with trip_id.

So the logic is: if the trip has a location_id and NO stop_id, trigger Zone-based Demand DRT

make sense?

@qcdyx qcdyx linked a pull request Jun 17, 2024 that will close this issue
5 tasks
@emmambd emmambd added do not merge This PR needs more work/discussion or is not meant to be merged and removed status: Needs triage Applied to all new issues labels Jun 17, 2024
@emmambd emmambd removed the do not merge This PR needs more work/discussion or is not meant to be merged label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants