Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for transfers.txt transfer_type=4 and 5 #1264

Closed
bdferris-v2 opened this issue Oct 4, 2022 · 0 comments · Fixed by #1266
Closed

Add validation for transfers.txt transfer_type=4 and 5 #1264

bdferris-v2 opened this issue Oct 4, 2022 · 0 comments · Fixed by #1266
Labels
GTFS Reference Used for Adding or changing rules that belong in the GTFS reference new rule New rule to be added status: Work in progress A PR that would close this issue has been opened.

Comments

@bdferris-v2
Copy link
Collaborator

Describe the problem

As discussed in google/transit/pull/303, the spec was recently amended to support two new values for transfers.txt transfer_type, 4 and 5, in support of in-seat transfers. We should extend the validator to accept these new values.

Describe the new validation rule

Extend GtfsTransferTypeEnum

Sample GTFS datasets

No response

Severity

No response

Additional context

No response
@bdferris-v2 bdferris-v2 added status: Needs triage Applied to all new issues new rule New rule to be added labels Oct 4, 2022
@bdferris-v2 bdferris-v2 mentioned this issue Oct 4, 2022
Merged
4 tasks
@isabelle-dr isabelle-dr added this to the v4.0 milestone Oct 4, 2022
@isabelle-dr isabelle-dr added GTFS Reference Used for Adding or changing rules that belong in the GTFS reference status: Work in progress A PR that would close this issue has been opened. and removed status: Needs triage Applied to all new issues labels Oct 4, 2022
@isabelle-dr isabelle-dr mentioned this issue Oct 4, 2022
Closed
@isabelle-dr isabelle-dr modified the milestones: v4.0, Q4 2022 Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GTFS Reference Used for Adding or changing rules that belong in the GTFS reference new rule New rule to be added status: Work in progress A PR that would close this issue has been opened.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add validation support for transfers.txt transfer_type 4 and 5. bdferris-v2/gtfs-validator
2 participants
@bdferris-v2 @isabelle-dr