Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of tz database time zones #146

Closed
richfab opened this issue Nov 18, 2024 · 2 comments · Fixed by #147
Closed

Update list of tz database time zones #146

richfab opened this issue Nov 18, 2024 · 2 comments · Fixed by #147

Comments

@richfab
Copy link
Contributor

richfab commented Nov 18, 2024

Context

As discussed in MobilityData/gbfs#697, the schemas don't match the spec currently for the allowed timezones.

Problem

The spec indicates: "Refer to https://en.wikipedia.org/wiki/List_of_tz_zones for a list of valid values" but the schemas don't contain all the values ​​from the list (e.g. 'America/Montreal' which used to be a canonical value but became a link to 'America/Toronto').

Solution

Replace the timezones in the schemas with the content of the TZ identifier column from this list.

This way, 'America/Montreal' will be considered valid by the validation tools (validator and schemas).

@leonardehrenfried
Copy link
Contributor

Is there going to be a release of the java model that contains these changes?

@richfab
Copy link
Contributor Author

richfab commented Dec 2, 2024

Is there going to be a release of the java model that contains these changes?

Good point @leonardehrenfried. We'll keep you posted about this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants