Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-23921] Include sum inputs & outputs to lineage response #171

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Feb 25, 2025

Change Summary

This is required to show sum of operations within run, and sum of runs within job in the lineage graph:
изображение

Instead of calling list_by_run_ids(granularity="RUN") + list_by_JOB_ids(granularity="JOB"), calling list_by_run_ids(granularity="RUN") + list_by_RUN_ids(granularity="JOB"). Otherwise lineage graph may include inputs & outputs of job with other datasets, not actually used by selected run_id or operation_id.

This logic can be implemented on UI side, but the code is quite ugly, so I've decided that it's better to move it to backend.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus requested a review from TiGrib February 25, 2025 11:19
@dolfinus dolfinus self-assigned this Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.04%. Comparing base (fcee1d6) to head (30eb9f0).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #171      +/-   ##
===========================================
+ Coverage    93.01%   93.04%   +0.03%     
===========================================
  Files          191      191              
  Lines         4495     4517      +22     
  Branches       298      302       +4     
===========================================
+ Hits          4181     4203      +22     
  Misses         253      253              
  Partials        61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus marked this pull request as ready for review February 25, 2025 11:31
@dolfinus dolfinus marked this pull request as draft February 27, 2025 07:35
@dolfinus dolfinus marked this pull request as ready for review February 27, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant