From f2151bf12d7b0bcc8e430a459ee2830ca35ce42b Mon Sep 17 00:00:00 2001 From: Elizabeth Russell Date: Wed, 5 Aug 2020 12:22:48 -0400 Subject: [PATCH] =?UTF-8?q?Resolve=20memory=20leak=20(https://github.com/d?= =?UTF-8?q?ropbox/Store/issues/197)=20by=20removing=20suspend=20keyword=20?= =?UTF-8?q?from=20RefCountedResource=E2=80=99s=20create=20lambda,=20to=20p?= =?UTF-8?q?revent=20it=20from=20capture=20by=20FetcherController=E2=80=99s?= =?UTF-8?q?=20onEach()?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../dropbox/android/external/store4/impl/RefCountedResource.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/store/src/main/java/com/dropbox/android/external/store4/impl/RefCountedResource.kt b/store/src/main/java/com/dropbox/android/external/store4/impl/RefCountedResource.kt index 9a125b10f..f531a6d31 100644 --- a/store/src/main/java/com/dropbox/android/external/store4/impl/RefCountedResource.kt +++ b/store/src/main/java/com/dropbox/android/external/store4/impl/RefCountedResource.kt @@ -22,7 +22,7 @@ import kotlinx.coroutines.sync.withLock * Simple holder that can ref-count items by a given key. */ internal class RefCountedResource( - private val create: suspend (Key) -> T, + private val create: (Key) -> T, private val onRelease: (suspend (Key, T) -> Unit)? = null ) { private val items = mutableMapOf()