Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MyInputMethodService #23

Open
nkrusch opened this issue Aug 8, 2020 · 1 comment
Open

Refactor MyInputMethodService #23

nkrusch opened this issue Aug 8, 2020 · 1 comment
Labels
low priority refactor Improve implementation of existing code

Comments

@nkrusch
Copy link
Contributor

nkrusch commented Aug 8, 2020

The entire keyboard is essentially contained within this 1 class. With more and more features the class is becoming increasingly challenging to manage and needs to be refactored into more manageable (smaller) classes.

One possibility is to make a class for each keyboard view: qwerty, azerty, numeric and symbolic keyboards and each of these classes manages its own functionality. For example shift key is only relevant in the alphabetic keyboard.

The first task here is to think about what would be the ideal way to organize this functionality. The above maybe not be ideal long term so do not limit to that organization alone. This is a low priority task.

@nkrusch nkrusch added enhancement New feature or request low priority labels Aug 8, 2020
@nkrusch nkrusch added refactor Improve implementation of existing code and removed enhancement New feature or request labels Dec 19, 2020
@NA0341
Copy link
Contributor

NA0341 commented Jan 7, 2023

You could ask the developers of other projects how they implemented their stuff (such as OpenBoard, Unexpected Keyboard or Simple Keyboard by SimpleMobileTools).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority refactor Improve implementation of existing code
Development

No branches or pull requests

2 participants