AudioBuffer / AudioBufferList Missing Constructors

[rdamiano]

This was something fixed late in development of OLD RoboVM, after going closed-source.

After the fix, this code in OLD RoboVM worked perfectly:

AudioBuffer audioBuffer = new AudioBuffer();
AudioBufferList fillBufferList = new AudioBufferList(new AudioBuffer[] { audioBuffer });

In MobiDevelop's RoboVM, this is no longer possible since AudioBuffer / AudioBufferFillList have no valid constructors:

AudioBuffer audioBuffer = AudioBuffer.AudioBufferPtr.malloc(AudioBuffer.class); // this is probably completely wrong, I was trying things
AudioBufferList fillBufferList = new AudioBufferList();
fillBufferList.setBuffers(new AudioBuffer[] { audioBuffer } ); // this argument should be in the constructor, like the Objective-C counterpart

This ^ code doesn't work at all and crashes.

I actually brought this up in support back when RoboVM was officially under development, and it was fixed quickly by the developers in a nightly so I assume this is a simple fix? (Please forgive my ignorance this stuff goes over my head a bit.)

This is for an app made back when RoboVM started, and I've since been working with OLD RoboVM but really want to update to MobiDevelop's version, this is so far the only obstacle.

[dkimitsa]

#160

[rdamiano]

Oh cheers @dkimitsa that seemed simple enough, thanks.

I realize I now need to wait for the pull request/commit/build etc so I just want to bring up the fact that the AudioBufferList second constructor is also missing (https://developer.apple.com/documentation/coreaudio/audiobufferlist). I bring this up because I'd hate to wait for the next build and then have it still not working.

I feel like the RoboVM AudioBufferList.setBuffers() function has a problem due to something not being initialized or set properly, I'm trying to remember what was said back when the original RoboVM team addressed this and added the constructor I use in the OP.

I could very well be wrong but I figure better safe than sorry rather than waiting and seeing it is indeed broken, if you don't mind tossing that constructor into another pull request? Appreciate it.

[dkimitsa]

I see the issue now, will take a look tomorrow

[dkimitsa]

@rdamiano #163

[rdamiano]

@dkimitsa Thanks a lot really appreciate your help with this stuff!

[florianf]

Merged the PR.

[rdamiano]

@dkimitsa @florianf Cool thanks a lot guys this was the only thing holding me up for moving to MobiDevelop's RoboVM. If I can be a nuisance one last time when do you think the next snapshot build will happen so I can compile with these merged changes?

[dkimitsa]

you can build RoboVM yourself for now it is quite easy

[rdamiano]

@dkimitsa huh you're right, that was easy, it did take a long time though lol

Sorry to keep coming back with questions, but all seems good, and it compiles (the changes you've applied in this PR are visible too). But regardless if I deploy or compile a release build, the process fails right after the step:

"Copying [AdHoc/Development] provisioning profile..."

No idea why, I haven't touched the profiles and they were just working a day ago when using the latest snapshot as well as old-RoboVM. You have any ideas? Maybe related to Xcode?

Edit: I can deploy a random project from Xcode (version 8.0).

[dkimitsa]

@rdamiano is there any other output in robovm tab besides ""Copying [AdHoc/Development] provisioning profile..." ?

[rdamiano]

@dkimitsa Nothing useful that I can tell, it's just going through the normal process and then fails. Here's a screenshot.

[dkimitsa]

could you please also check Idea log as there will be a little bit more about NullPointerException

[rdamiano]

@dkimitsa Okay didn't know about the logs, here's I believe the relevant output:

!ENTRY org.robovm.eclipse 4 0 2017-06-16 08:08:11.431
!MESSAGE Packaging failed. Check the RoboVM console for more information.
!STACK 0
java.lang.RuntimeException: java.lang.NullPointerException
	at org.robovm.compiler.target.ios.IOSTarget.getOrCreateEntitlementsPList(IOSTarget.java:495)
	at org.robovm.compiler.target.ios.IOSTarget.prepareInstall(IOSTarget.java:354)
	at org.robovm.compiler.target.ios.IOSTarget.archive(IOSTarget.java:560)
	at org.robovm.compiler.AppCompiler.archive(AppCompiler.java:803)
	at org.robovm.eclipse.internal.actions.CreateIPAAction$1$1.doCompile(CreateIPAAction.java:127)
	at org.robovm.eclipse.internal.AppCompilerThread.run(AppCompilerThread.java:66)
Caused by: java.lang.NullPointerException
	at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:1792)
	at org.apache.commons.io.IOUtils.copyLarge(IOUtils.java:1769)
	at org.apache.commons.io.IOUtils.copy(IOUtils.java:1744)
	at org.apache.commons.io.IOUtils.toByteArray(IOUtils.java:462)
	at org.robovm.compiler.target.ios.IOSTarget.getOrCreateEntitlementsPList(IOSTarget.java:477)
	... 5 more

[dkimitsa]

it was broken by one of commits, check #168 i've created
meanwhile please add Entitlement.list to your project (and robovm.xml) is compiling against device. Simulator shall be not affected

[rdamiano]

@dkimitsa Yep that did it, alright cool thanks again for all the help looks like I'm up and running now ;)