Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sendUnhandled wasn't working correctly #98

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix: sendUnhandled wasn't working correctly #98

merged 2 commits into from
Jul 30, 2024

Conversation

TheRealAgentK
Copy link
Contributor

@TheRealAgentK TheRealAgentK commented Jul 17, 2024 •
edited by sumitramanga
Loading

fix: #72 - sendUnhandled was't working correcly

Description 📝

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Updates

👉 Fixed RaygunClient where sendUnhandled wasn't falling through to the correct implementation
👉 Improved flow in sampleapp to remove ambiguities around what's actually happening in there when I was tr

Author to check 👓

  • Project and all contained modules builds successfully
  • Self-/dev-tested
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Project and all contained modules builds successfully
  • Change has been dev-/reviewer-tested, where possible
  • Unit/UI/Automation/Integration tests provided where applicable
  • Code is written to standards
  • Appropriate documentation written (code comments, internal docs)

@TheRealAgentK TheRealAgentK requested review from a team, nikz, miquelbeltran, PanosNB, sumitramanga, ProRedCat and redJ4y and removed request for a team and PanosNB July 17, 2024 07:41
sumitramanga
sumitramanga approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@sumitramanga sumitramanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@TheRealAgentK TheRealAgentK merged commit da7b19a into master Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumitramanga sumitramanga sumitramanga approved these changes

@nikz nikz Awaiting requested review from nikz nikz was automatically assigned from MindscapeHQ/kai-miquel-and-friends

@miquelbeltran miquelbeltran Awaiting requested review from miquelbeltran miquelbeltran was automatically assigned from MindscapeHQ/kai-miquel-and-friends

@ProRedCat ProRedCat Awaiting requested review from ProRedCat

@redJ4y redJ4y Awaiting requested review from redJ4y

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug in Raygunclient sendUnhandled?
2 participants
@TheRealAgentK @sumitramanga