Skip to content

Conversation

@smorci
Copy link
Contributor

@smorci smorci commented Mar 26, 2024

Explain your changes:

  • Add missing-blocks-guardian script which is inspired from download-missing-blocks
  • Copy script to archive debian package

Explain how you tested your changes:

  • local test on a healthy mainnet archive database hosted on AWS by MF
  • I am interested in testing it on a broken database
  • I am interested in testing it from the debian package

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Test on broken DB
  • Test from debian package

The script should always report some meaningful message be that usage, error or just info. If other behavior is noticed, please notify me.

@emberian I included you because this will be included in the maintenance replayer package once it is done.

@dkijania could you help me come up with an idea to test it on a broken DB?

@smorci smorci requested review from dkijania, emberian and kaozenn March 26, 2024 15:26
@smorci smorci self-assigned this Mar 26, 2024
@smorci smorci requested review from a team as code owners March 26, 2024 15:26
@dkijania
Copy link
Member

@smorci in order to test script against broken database I propose you to utilize archive-block app and devnet or mainnet precomputed blocks. scenario would look like below:

  1. Create empty mainnet database with schema only
  2. Using gsutil download precomputed blocks from o1labs bucket (mina_network_block_data) with prefix devnet or mainnet. You can skip some height (precomputed blocks name format is {network-height-state-hash.json} so you can easily avoid particular heights in order to prepare broken db
  3. Using archive block app import into database downloaded precomputed blocks
  4. Run guardian

@dkijania
Copy link
Member

I've tested script using mainnet network . Looking good

@dkijania
Copy link
Member

@smorci I think we can remove src/app/rosetta/download-missing-blocks.sh script which duplicates script you just developed

@dkijania
Copy link
Member

!ci-build-me

@smorci smorci force-pushed the smorci/missing-blocks-guardian-compatible branch from 6d0630d to c56c11f Compare March 28, 2024 10:06
@dkijania
Copy link
Member

!ci-build-me

@smorci
Copy link
Contributor Author

smorci commented Mar 28, 2024

!ci-build-me

@smorci smorci force-pushed the smorci/missing-blocks-guardian-compatible branch from 29b58e7 to 2ada138 Compare March 28, 2024 14:22
@smorci
Copy link
Contributor Author

smorci commented Mar 28, 2024

!ci-build-me

@dkijania
Copy link
Member

!ci-build-me

@dkijania dkijania merged commit 0ba6bea into compatible Mar 28, 2024
@dkijania dkijania deleted the smorci/missing-blocks-guardian-compatible branch March 28, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants