Skip to content

Conversation

@vanarasiantonyswamy
Copy link
Contributor

@vanarasiantonyswamy vanarasiantonyswamy commented Aug 2, 2023

Explain your changes:

  • CI fixes for failures in Mainnet master build
    Removed below Test as client SDK is deprecated
    Publish client SDK to npm
    Prepublish client SDK packages
    Fixed: [changed batch/v1beta1 to batch/v1 [this was done v1beta1 is no longer available in kubernetes] ]
    payment integration test
    Helm chart lint
    archive-node integration test

Explain how you tested your changes:

  • Running the build and watching the jobs pass
  • for client SDK, we removed the dhall test files & .sh script that referenced.

Checklist:

  • [ N/A] Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • [N/A ] Modified the current draft of release notes with details on what is completed or incomplete within this project
  • [ N/A] Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • [ N/A] Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • [✅] All tests pass (CI will check this if you didn't)
  •  I do not see the removed test in the build
              Publish client SDK to npm
              Prepublish client SDK packages
    
  •  I see the 3 tests fixed are now green
             payment integration test 
             Helm chart lint
            archive-node integration test
    
  • [N/A ] Serialized types are in stable-versioned modules
  • [ N/A] Does this close issues? List them

@vanarasiantonyswamy vanarasiantonyswamy requested review from a team as code owners August 2, 2023 20:42
@vanarasiantonyswamy vanarasiantonyswamy changed the title Vani mainnet c ifixes Vani mainnet ci fixes Aug 3, 2023
@stevenplatt stevenplatt merged commit ed54a7b into master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants