kimchi-bindings/js: back on nightly and use 2023-09-18

nightly has been initially removed as it seemed to make vendoring all the
dependencies more complicated (which seems to not be the case though).
However, removing nightly introduces issues like "DataCloneError", see
o1-labs/o1js#1989, which makes the reliance on
nightly inevitable.
It seems that --offline works out of the box.

Another note is that cargo vendor has been introduced to provide a
consistent build environment for all platforms and all users, including
the CI. The lockfile Cargo.lock is meant to provide a locked environment
with all the dependencies, including the transitive ones. However, it is
only used by binaries. In our build process, we do build a static
library (libwires_15_stubs.a), not a binary. And Rust doesn't use the
lockfile in this case.
Another solution than `cargo vendor` would have been to strictly enforce
the version in the top-level Cargo.toml, but it implies to add all the
transitive dependencies (as otherwise, when a new transitive dependency
is released, cargo will fetch it, making the environment inconsistent).
This solution is not viable as the purpose of Cargo.toml is to enforce
versions on direct dependencies only, and leave the cargo solver doing
its job for the transitive dependencies.
For these reasons, the solution of vendoring the dependencies to build
the static library has been selected.

Author: dannywillems

src/lib/crypto/kimchi_bindings/js/node_js/build.sh

@@ -3,8 +3,7 @@ set -euo pipefail
 
 if [[ -z "${PLONK_WASM_NODEJS-}" ]]; then
     export RUSTFLAGS="-C target-feature=+atomics,+bulk-memory,+mutable-globals -C link-arg=--no-check-features -C link-arg=--max-memory=4294967296"
-    # The version should stay in line with the one in kimchi_bindings/wasm/rust-toolchain.toml
-    rustup run 1.72 wasm-pack build --target nodejs --out-dir ../js/node_js ../../wasm -- --features nodejs --offline
+    wasm-pack build --target nodejs --out-dir ../js/node_js ../../wasm -- -Zbuild-std=std,panic_abort --features nodejs --offline
 else
     cp "$PLONK_WASM_NODEJS"/* -R .
 fi

src/lib/crypto/kimchi_bindings/js/node_js/dune

@@ -31,6 +31,8 @@
   ;; Required as we use Cargo workspace, and the build requires the Cargo.toml
   ;; and sources for each members
   ../../wasm/Cargo.toml
+  ;; Enforcing the rust version used for the build
+  ../../wasm/rust-toolchain.toml
   (source_tree ../../wasm/src))
  (locks /cargo-lock) ; lock for rustup
  (action

src/lib/crypto/kimchi_bindings/js/web/build.sh

@@ -3,8 +3,7 @@ set -euo pipefail
 
 if [[ -z "${PLONK_WASM_WEB-}" ]]; then
     export RUSTFLAGS="-C target-feature=+atomics,+bulk-memory,+mutable-globals -C link-arg=--no-check-features -C link-arg=--max-memory=4294967296"
-    # The version should stay in line with the one in kimchi_bindings/wasm/rust-toolchain.toml
-    rustup run 1.72 wasm-pack build --target web --out-dir ../js/web ../../wasm -- --offline
+    wasm-pack build --target web --out-dir ../js/web ../../wasm -- --offline -Zbuild-std=std,panic_abort
 else
     cp "$PLONK_WASM_WEB"/* -R .
 fi

src/lib/crypto/kimchi_bindings/js/web/dune

@@ -31,6 +31,8 @@
   ;; Required as we use Cargo workspace, and the build requires the Cargo.toml
   ;; and sources for each members
   ../../wasm/Cargo.toml
+  ;; Enforcing the rust version used for the build
+  ../../wasm/rust-toolchain.toml
   (source_tree ../../wasm/src))
  (locks /cargo-lock) ; lock for rustup
  (action

src/lib/crypto/kimchi_bindings/wasm/rust-toolchain.toml

@@ -1,5 +1,8 @@
+# Used to build stanzas in ../js/node_js and ../js/web.
+#
+# 2023-09-18 is used because serde 1.0.217 uses the feature Saturating not
+# working for versions before 2023-09-18
+# For more information regarding the usage of nightly, see
+# https://github.com/o1-labs/o1js/issues/1989
 [toolchain]
-# This should stay in line with the versions in
-# - kimchi_bindings/js/node_js/build.sh
-# - kimchi_bindings/js/web/build.sh
-channel = "1.72"
+channel = "nightly-2023-09-18"