Added TACGRP.TSK.CNT / CONTAIN Graphic (G*T*J-----****X) #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2021 15:50
Also added quick geometry function to test if a set of points are clockwise
Originally tried using a line dash styling option (ol/Style/Stroke/setLineDash), however it looked weird when zooming because the dash lengths remained constant as the shape grew and shrank.
Author
|
I didn't realize the "Added Counterattack" commit was going to be added to the pull request because it was made after the pull request was created but, here is an image of that: |
ondrej-podolsky
approved these changes
Mar 26, 2021
Member
ondrej-podolsky
left a comment
ondrej-podolsky
left a comment
There was a problem hiding this comment.
LGTM, thank you for solving this!
Member
|
Great work @Vac1911 , thanks for contributing! |
Author
|
No problem :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TACGRP.TSK.CNT / CONTAIN Graphic (GTJ-----****X).
Also added quick geometry function to test if a set of points are clockwise.
I am opening a pull request to your fork (rather than the main repo) as I plan to create boundary/line based contributions in the future. This is just me getting my feet wet in this project.
Screen shot of added graphic (example data included in /example-data/tacticaljson/contain.json):
