Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch torrent URLs with custom regular expressions not working #147

Open
Latonki opened this issue Apr 1, 2023 · 4 comments
Open

Catch torrent URLs with custom regular expressions not working #147

Latonki opened this issue Apr 1, 2023 · 4 comments
Labels

Comments

@Latonki
Copy link

Latonki commented Apr 1, 2023

I'm trying to create regular expressions so that Torrent Control will only catch the torrent URLs from specific trackers. I was able to create a regular expression and I ticked catch torrent URLs before inputting my regular expression into the textbox but the issue was that after I clicked save, closed the addon page, and then reopen the addon page, the regular expression disappeared.

@Mika- Mika- added the bug label Jun 5, 2023
@jimbobjonesbob
Copy link

same thing here.

@vasyl83
Copy link

vasyl83 commented Jan 30, 2024

same!, worked before I had to reinstall windows, once I got firefox back. I had that error on clean install of firefox and this addon

@KaiStarkk
Copy link

KaiStarkk commented Nov 2, 2024

If the save button isn't becoming inactive after you click it, it isn't saving.
The issue is likely caused by a malformed regular expression. The test tool is more lenient than the checker that is used when saving.

You probably have something like this:
https://www.domain.net/tor/download.php/

and need to convert it to a regular expression like this:

/^https:\/\/www\.domain\.net\/tor\/download\.php\/.*$/

@Mika- not sure if the checker could bubble up the error message as an alert?

@Mika-
Copy link
Owner

Mika- commented Nov 17, 2024

Currently there's no warning about malformed regular expressions. Should really add one that atleast says which one is broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants