Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robots do not gain experience from villager trading #3289

Open
kraetzin opened this issue May 6, 2020 · 1 comment
Open

Robots do not gain experience from villager trading #3289

kraetzin opened this issue May 6, 2020 · 1 comment
Labels
bug OC feature is broken
Milestone

Comments

@kraetzin
Copy link

kraetzin commented May 6, 2020

Outline

I have a robot equiped with an experience upgrade in a Tier 3 upgrade container, as well as an internal trading upgrade. The aim is to have the robot trade with villagers and pick up the experience, leveling up the experience upgrade. This would then be rotated out to other robots.

Issue:

After executing a trade, experience orbs drop around the villagers. These are not picked up by the robot, unlike in mining, for example. Calling robot.suck() on the experience orbs does nothing either.

Expected behaviour:

The robot should automatically gain the experience resulting from an executed trade, if it has an experience upgrade.

Version information:
OpenComputers-MC1.12.2-1.7.5.192

@payonel payonel self-assigned this May 26, 2020
@payonel payonel added the bug OC feature is broken label May 11, 2021
@payonel payonel removed their assignment May 15, 2021
@asiekierka asiekierka added this to the OC 1.8.0 milestone Jun 8, 2022
@asiekierka asiekierka modified the milestones: OC 1.8.0, OC 1.9.0 May 30, 2023
@zeng-github01
Copy link

zeng-github01 commented Apr 11, 2024

Based on the existing code, there is no way to fix this problem without making breaking changes. I have an idea: add the ability to suck surrounding experience orbs to the robot. At the same time, modify the existing experience acquisition method and switch to using this solution to solve the problem.

@asiekierka What do you think? I have implemented the function of suck surrounding experience orbs, but it seems that the generation of experience orbs is delayed. Executing experience.suck immediately after completing a trade will cause the experience value of the previous trade to be sucked.

Edit: Robot mining does not seem to produce experience orbs. If this is the case, then there is no need to make any modifications to the existing OC code. Just merge this proactive absorption patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OC feature is broken
Projects
None yet
Development

No branches or pull requests

4 participants