Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate DenierSigner from microsoft-recommended-driver-block-rules #11979

Open
wants to merge 2 commits into
base: public
Choose a base branch
from

Conversation

HotCakeX
Copy link
Contributor

The following DeniedSigner is mentioned twice which isn't supposed to happen.

<DeniedSigner SignerId="ID_SIGNER_ECSIODRV" />

Only one is enough, there is only one signer referencing it

 <Signer ID="ID_SIGNER_ECSIODRV" Name="GlobalSign Primary Object Publishing CA">
      <CertRoot Type="TBS" Value="879269F3F467A6D59641960A62FE9CB419355FF6" />
      <CertPublisher Value="ELITEGROUP COMPUTER SYSTEMS CO" />
      <FileAttribRef RuleID="ID_FILEATTRIB_ECSIODRV" />
    </Signer>

So I just removed the extra DenierSigner, everything checks out now and is valid according to the CI Schema.

@github-actions github-actions bot added the Tier3 label Dec 26, 2024
Copy link
Contributor

Learn Build status updates of commit ffa6237:

✅ Validation status: passed

File Status Preview URL Details
windows/security/application-security/application-control/app-control-for-business/design/microsoft-recommended-driver-block-rules.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@aczechowski aczechowski requested a review from jgeurten December 26, 2024 19:40
Copy link
Contributor

Learn Build status updates of commit 17d7fc2:

✅ Validation status: passed

File Status Preview URL Details
windows/security/application-security/application-control/app-control-for-business/design/microsoft-recommended-driver-block-rules.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant