Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git stash icon is a bad fit #64423

Closed
jrieken opened this issue Dec 5, 2018 · 13 comments
Closed

Git stash icon is a bad fit #64423

jrieken opened this issue Dec 5, 2018 · 13 comments
Assignees

Comments

@jrieken
Copy link
Member

jrieken commented Dec 5, 2018

The new git stash icon isn't a good fit and appears must more heavy/bold than other icons.

screenshot 2018-12-05 at 12 09 57

@joaomoreno
Copy link
Member

joaomoreno commented Dec 6, 2018

I agree. But you gotta go talk to GitLens. 😆 cc @eamodio

@jrieken
Copy link
Member Author

jrieken commented Dec 6, 2018

🤣

@eamodio
Copy link
Contributor

eamodio commented Dec 6, 2018

😄 Do you not like the command there or just the icon itself? If just the icon is this any better?

image

I've definitely struggled with iconifying the stash commands.

Also FYI, I will be adding a setting to turn off those SCM menu additions as I just realized I was missing that control - while I have it for all of the other additions)

@usernamehw
Copy link
Contributor

usernamehw commented Dec 6, 2018

What about pack unpack sort of icons:

⬆️ From: https://www.iconfinder.com/icons/507777/arrow_box_crate_downwards_pack_ship_icon

16px

@eamodio
Copy link
Contributor

eamodio commented Dec 6, 2018

They would be even heavier than the current icon and at 16px I think they would be really hard to see.

@jrieken
Copy link
Member Author

jrieken commented Dec 6, 2018

Do you not like the command there or just the icon itself?

Now that you ask me, actually not sure. I always like less UI so yeah, I probably don't want the icon there.

@eamodio
Copy link
Contributor

eamodio commented Dec 6, 2018

Is the alternative icon less offensive or not an improvement? 😉

@jrieken
Copy link
Member Author

jrieken commented Dec 6, 2018

yeah, better/lighter but still an icon. I'd prefer a secondary command in the context-menu

@eamodio
Copy link
Contributor

eamodio commented Dec 6, 2018

Here one more alternative
image

@eamodio
Copy link
Contributor

eamodio commented Dec 19, 2018

Fixed in GitLens 9.2.2

@joaomoreno
Copy link
Member

@misolori We're still having people which are confused by the icon. #65715

I wonder if you have some thoughts?

@miguelsolorio
Copy link
Contributor

It seems to me that other git clients use some type of arrow:

GitKraken Sublime Merge
image image

Played around with a few Octicons to see which could work better and this is the only one I found that was decent enough (though not sure if it's any better):
image

@joaomoreno
Copy link
Member

Ohh I like that! What do you think @jrieken @eamodio?

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants