Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOM crash when searching from the viewlet in a file that consists of a single 100MB line #31551

Closed
michelkaporin opened this issue Jul 27, 2017 · 4 comments
Closed

OOM crash when searching from the viewlet in a file that consists of a single 100MB line #31551

michelkaporin opened this issue Jul 27, 2017 · 4 comments
Assignees
@roblourens @rebornix
Labels
bug Issue identified by VS Code Team member as probable bug editor-textbuffer Editor text buffer search Search widget and operation issues verified Verification succeeded
Milestone
August 2018

Comments

@michelkaporin
Copy link
Contributor

Testing #30243

  1. Generate file as in Change all occurrences in a single 100MB line leads to a crash when autosave on #31545 and open it.
  2. Add some text you would like to search for in several places.
  3. Open search viewlet and search for the text.

VS Code crashes.
@alexdima alexdima changed the title Crash when searching from the viewlet for 100MB file OOM crash when searching from the viewlet in a file that consists of a single 100MB file Aug 10, 2017
@alexdima alexdima changed the title OOM crash when searching from the viewlet in a file that consists of a single 100MB file OOM crash when searching from the viewlet in a file that consists of a single 100MB line Aug 10, 2017
@alexdima
Copy link
Member

@roblourens Do we restrict the search results preview in the viewlet to a region around the match or do we dump the entire matching line in the DOM ?

@roblourens
Copy link
Member

roblourens commented Aug 10, 2017 •
edited
Loading

Searching in files with long lines has always been an issue. Need to change how it's handled in the viewlet and also at every point upstream. I think there's another issue for this but I can't find it. With better large file support, I should work on this.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Aug 10, 2017
@alexdima
Copy link
Member

@roblourens 👍 . I would consider this a low-priority, source code or log files that consist of a single 100MB line sound pretty unrealistic to me.

@roblourens roblourens mentioned this issue Aug 22, 2017
Closed
@roblourens roblourens mentioned this issue Sep 18, 2017
Merged
@roblourens roblourens mentioned this issue Nov 23, 2017
Closed
This was referenced Mar 29, 2018
Closed
Closed
@alexdima alexdima added the editor-textbuffer Editor text buffer label Apr 18, 2018
@alexdima alexdima assigned rebornix and unassigned alexdima Apr 18, 2018
@roblourens roblourens mentioned this issue Apr 30, 2018
Closed
@roblourens roblourens added this to the August 2018 milestone Aug 25, 2018
@roblourens roblourens mentioned this issue Aug 28, 2018
Closed
2 tasks
@sbatten sbatten added the verified Verification succeeded label Aug 28, 2018
@sbatten
Copy link
Member

sbatten commented Aug 28, 2018

verified but did see the other known issue of reporting one extra character on matches

@roblourens roblourens mentioned this issue Sep 12, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug editor-textbuffer Editor text buffer search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
August 2018
Development

No branches or pull requests
5 participants
@roblourens @rebornix @michelkaporin @alexdima @sbatten