Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension removes all cell metadata on execute #2325

Closed
gitjeff05 opened this issue Feb 8, 2020 · 3 comments
Closed

Extension removes all cell metadata on execute #2325

gitjeff05 opened this issue Feb 8, 2020 · 3 comments
Assignees

Comments

@gitjeff05
Copy link

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

1.) Open or create a notebook in using jupyter lab
2.) Save a few cells and insert cell metadata for those cells
3.) Save notebook and close
4.) Open same notebook in vscode
5.) Execute those cells

Actual behavior

All cell metadata is deleted upon execution of the cell in vscode

Expected behavior

Cells should inherit the metadata originally entered.

Your Jupyter and/or Python environment

Please provide as much info as you readily know

  • Jupyter server running: Local
  • Extension version: 2020.1.58038
  • VS Code version: Version: 1.41.1
  • Setting python.jediEnabled: ?
  • Python and/or Anaconda version: Python 3.7.4
  • OS: Mac:
  • Virtual environment: conda

I am running this off of a docker container https://github.com/jupyter/docker-stacks/blob/master/scipy-notebook

I am not sure that matters. I can connect and run cells just fine. But the cell metadata is overwritten when executing the cells in vscode.

I did see this error in the console, but I'm not sure if it was related:

[E 13:27:18.397 LabApp] Notebook JSON is invalid: 'ename' is a required property

    Failed validating 'required' in error:

    On instance['cells'][0]['outputs'][0]:
    {'evalue': 'Error: Failed to connect to remote Jupyter notebook.\r\n'
               'Check that...',
     'output_type': 'error'}
@DavidKutu
Copy link

Thank you for letting us know @gitjeff05. I've been trying it and I can also reproduce the issue. We'll get to it shortly.

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Feb 10, 2020

@gitjeff05 We have fixed part of the issue, we now no longer add invalid metadata into the cells. I.e. the JSON is now valid when you attempt to open the notebook from Jupyter Notebooks/labs or similar.

You can install the latest insiders build of the extension from here https://github.com/microsoft/vscode-python/blob/master/CONTRIBUTING.md#development-build or you could wait for the next release (some time today 🤞 )

However the issue with throwing away the metadata still exists.

@rchiodo rchiodo self-assigned this Feb 14, 2020
@IanMatthewHuff IanMatthewHuff self-assigned this Feb 20, 2020
@IanMatthewHuff
Copy link
Member

Validated. Cell metadata is now maintained.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
@microsoft microsoft unlocked this conversation Nov 13, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants