-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRU list for server connections is now super slow with kernel work #2533
Comments
Do we even need to check if the url is alive (reachable)? Unsure how kernel work world have impacted this, as it's unrelated. |
Honestly, right now I'm having trouble replicating the really bad perf. Now it's only a 4-5 second wait, which might be acceptable. But getRunningServerDetails is getting called for every server in the list many of which might be remote. And it's going to call Kernel.listRunning on everything in there. Seems like this would always have the possibility of hitting bad cases. Can we change the pick items after we've submitted them? If not I don't think any degree of hitting servers and querying kernels would be acceptable personally. |
We should have a way to tell if it's running or not though? Wouldn't that be useful to the user? |
Should we add telemetry to see how long it takes to popup this list in the wild? |
Yeah I think so. |
We already do. SelectJupyterURI |
From discussion. We don't want to hit a server at all to pop up a MRU list. Proposed plan. Save a list of X (5? 10?) servers in global VS Code cache. With each save the last time that we were connected to it. Display the name and the last time we connected to it in the MRU list. |
Validated |
One basic scenario to demo this:
In this scenario the only difference between servers A and B is the token. As such, when trying to populate the MRU list it's going to try sending lots of kernel API requests with the old A token to the new B server. In the command windows for the jupyter server on CPU B you can see all the 403 forbidden requests for this. In this scenario for me opening up the "Remote or Local" command and actually seeing the selection box takes over 30 seconds with no progress shown.
The text was updated successfully, but these errors were encountered: