Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle between markdown and code cell puts you into edit mode #2562

Closed
IanMatthewHuff opened this issue Dec 13, 2019 · 5 comments
Closed

Toggle between markdown and code cell puts you into edit mode #2562

IanMatthewHuff opened this issue Dec 13, 2019 · 5 comments
Assignees

Comments

@IanMatthewHuff
Copy link
Member

Noticed this while validating the 'y' 'm' keyboard issue. In jupyter 'y' 'm' don't put you into edit mode, but in our tool we do. This is worse because if I try to toggle back I'm now entering code. We should not go into edit more on changing cell type.

@DonJayamanne DonJayamanne self-assigned this Feb 7, 2020
@DonJayamanne
Copy link
Contributor

Picking this as this is an area that will get modified as part of the ds/custom_editor work.
Would like to avoid dup work and merge conflicts as well.

@rchiodo
Copy link
Contributor

rchiodo commented Feb 10, 2020

This is still happening. 'y' and 'm' still put the user into edit mode.

@DonJayamanne
Copy link
Contributor

Oh shoot, I was under the impression custom editor will be going in.
Since this touched some code that was getting modified in custom editor, I applied the fixes in custom editor branch.

@DonJayamanne
Copy link
Contributor

I guess now we'd want to bring them into master... dang!

@rchiodo
Copy link
Contributor

rchiodo commented Feb 14, 2020

Validated

@rchiodo rchiodo closed this as completed Feb 14, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants