Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook: Missing icons #2643

Closed
kuelumbus opened this issue Dec 6, 2019 · 12 comments
Closed

Notebook: Missing icons #2643

kuelumbus opened this issue Dec 6, 2019 · 12 comments
Assignees

Comments

@kuelumbus
Copy link

Bug: Notebook Editor, Interactive Window, Editor cells

Steps to cause the bug to occur

Open *.ipynb file

Actual behavior

Icons are missing in some *.ipynb files. (Only large files?)

image

It seems like that only the icons are missing. I can click a button in the bar and see tool tips of the buttons.

Expected behavior

image

Version: 1.41.0-insider
Commit: d386b49dee6267238389c0a616af2be89726a4e3
Date: 2019-12-06T12:19:10.032Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.0.0-37-generic snap

Your Jupyter and/or Python environment

Please provide as much info as you readily know

  • Jupyter server running: Local (via remote SSH)
  • Extension version: 2019.11.50794
  • Setting python.jediEnabled: false
  • Python and/or Anaconda version: 3.7
  • OS: Ubuntu 16.04
  • Virtual environment: virtualenv

Developer Tools Console Output

Probably not related.

[uncaught exception]: Error: Cannot read property 'reprocess' of undefined
TypeError: Cannot read property 'reprocess' of undefined
    at C.onDefaultConfigurationChanged (file:///snap/code-insiders/328/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:4593:537)
    at file:///snap/code-insiders/328/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:4585:949
    at c.fire (file:///snap/code-insiders/328/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:114:893)
    at Object.registerConfigurations (file:///snap/code-insiders/328/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1648:442)
    at Object.registerConfiguration (file:///snap/code-insiders/328/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1648:115)
    at file:///snap/code-insiders/328/usr/share/code-insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:2844:85
onUnexpectedError @ bootstrap-window.js:213
bootstrap-window.js:216 Error: Cannot read property 'reprocess' of undefined

TypeError: Cannot read property 'reprocess' of undefined
    at C.onDefaultConfigurationChanged (configurationService.ts:498)
    at configurationService.ts:97
    at c.fire (event.ts:581)
    at Object.registerConfigurations (configurationRegistry.ts:195)
    at Object.registerConfiguration (configurationRegistry.ts:182)
    at externalTerminalService.ts:369
    at errors.ts:26
onUnexpectedError @ bootstrap-window.js:216
2console.ts:137 [Extension Host] (node:4283) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. (at writeOut (internal/process/warning.js:27:3))
@jmew
Copy link
Contributor

jmew commented Dec 6, 2019

Thanks for the bug report, do you have an example notebook that you could provide that caused this issue for you so we can look into it further?

@kuelumbus
Copy link
Author

@jmew
Copy link
Contributor

jmew commented Dec 6, 2019

Yup i'm able to reproduce this issue.
image

We'll look into it, thanks for brining it up @kuelumbus!

@DavidKutu DavidKutu self-assigned this Jan 8, 2020
@rchiodo
Copy link
Contributor

rchiodo commented Jan 21, 2020

Validated. Fix will be in next insider's build.

@rchiodo rchiodo closed this as completed Jan 21, 2020
@kuelumbus
Copy link
Author

kuelumbus commented Jan 23, 2020

Hmm, I now get an error when opening the notebook
(https://nbviewer.jupyter.org/github/bmabey/pyLDAvis/blob/master/notebooks/pyLDAvis_overview.ipynb)

image

I am using the daily channel.

@DavidKutu
Copy link

I can't repro that on today's build. And searching for '<' it only appears on correct places.
Can you please double check that you are using a clean download of the notebook?

@kuelumbus
Copy link
Author

Sorry, you're right. The file was corrupt. However, the icons are still missing.

image

@DavidKutu
Copy link

DavidKutu commented Jan 24, 2020

Do you mind making sure your extension version in insiders is: 2020.2.59860-dev ?

@kuelumbus
Copy link
Author

Oh, I am apparently not using the daily channel. My version is 2020.1.58038. However, when I change "python.insidersChannel" to "daily", reload the window and open an notebook, it automatically changes "insidersChannel" to "off".

@rchiodo
Copy link
Contributor

rchiodo commented Jan 24, 2020

I believe that setting is forced to off if you're not actually using an insider's build.

You have to install an insider's build by hand.

@kuelumbus
Copy link
Author

Probably this one microsoft/vscode-python#9543

@kuelumbus
Copy link
Author

I believe that setting is forced to off if you're not actually using an insider's build.

You have to install an insider's build by hand.

This works. Thanks.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2020
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants