Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylint configuration in ~ is not detected on Windows #838

Closed
MikhailArkhipov opened this issue Feb 20, 2018 · 1 comment · Fixed by #845
Closed

Pylint configuration in ~ is not detected on Windows #838

MikhailArkhipov opened this issue Feb 20, 2018 · 1 comment · Fixed by #845
Assignees
@MikhailArkhipov
Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Milestone
February 2018

Comments

@MikhailArkhipov
Copy link

path.resolve('~') actually resolves to vscode directory "C:\Program Files\Microsoft VS Code\~"
@MikhailArkhipov MikhailArkhipov added bug Issue identified by VS Code Team member as probable bug area-linting needs PR labels Feb 20, 2018
@MikhailArkhipov MikhailArkhipov added this to the February 2018 milestone Feb 20, 2018
@MikhailArkhipov MikhailArkhipov self-assigned this Feb 20, 2018
@DonJayamanne
Copy link

You need to use untildify (we are using an npm package for that).

@MikhailArkhipov MikhailArkhipov mentioned this issue Feb 21, 2018
Merged
MikhailArkhipov pushed a commit that referenced this issue Feb 21, 2018
#730, #838 (#845)
b5d59ff 
* Fix pylint search

* Handle quote escapes in strings

* Escapes in strings

* CR feedback

* Missing pip

* Test

* Tests

* Tests

* Mac python path

* Tests

* Tests

* Test

* "Go To Python object" doesn't work

* Proper detection and type population in virtual env

* Test fixes

* Simplify venv check

* Remove duplicates

* Test

* Discover pylintrc better + tests

* Undo change

* CR feedback

* Set interprereter before checking install

* Fix typo and path compare on Windows

* Rename method

* #815 - 'F' in flake8 means warning

* 730 - same folder temp

* Properly resolve ~

* Test

* Test
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MikhailArkhipov MikhailArkhipov

Labels
area-linting bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
February 2018
Development

Successfully merging a pull request may close this issue.

#730, #838
3 participants
@brettcannon @DonJayamanne @MikhailArkhipov