Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX adjustments for line numbers in the notebooks editor #2770

Closed
ronglums opened this issue Oct 30, 2019 · 7 comments
Closed

UX adjustments for line numbers in the notebooks editor #2770

ronglums opened this issue Oct 30, 2019 · 7 comments
Assignees

Comments

@ronglums
Copy link
Contributor

Turn on line numbers for cells in the notebook editor. see if we can make adjustments so it's consistent with the regular VS Code editor.

  1. Line numbers font color to be the same as a regular editor
  2. The vertical line b/w line numbers and code to be editor background color
  3. increase space b/w line numbers and code

image

@rchiodo
Copy link
Contributor

rchiodo commented Oct 30, 2019

  1. is already true? Not sure what you mean

@tbrodbeck
Copy link

How can I turn on line numbers in a vscode notebook?

@rchiodo
Copy link
Contributor

rchiodo commented Oct 31, 2019

@tbrodbeck, hit the 'L' key when a cell is selected.

@ronglums
Copy link
Contributor Author

@rchiodo for microsoft/vscode-python#1, the line number colors are not the same as in a regular editor. see the screenshots below.

image

image

@rchiodo
Copy link
Contributor

rchiodo commented Oct 31, 2019

Oh, they might have custom colors in the theme for that. Uggh.

@DonJayamanne DonJayamanne self-assigned this Oct 31, 2019
@DonJayamanne
Copy link
Contributor

Here's what it looks like now (the image on top is the native editor, and the one at the bottom in VSC editor with the same text).
Using same styles from VSC themes.

Screen Shot 2019-10-31 at 14.55.27.pngScreen Shot 2019-10-31 at 14.56.52.png

@IanMatthewHuff IanMatthewHuff self-assigned this Nov 1, 2019
@IanMatthewHuff
Copy link
Member

Validated with a half dozen or so themes.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 8, 2019
@microsoft microsoft unlocked this conversation Nov 14, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants