Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DebugAdapterTracker for logging #8106

Closed
karthiknadig opened this issue Oct 18, 2019 · 4 comments
Closed

Use DebugAdapterTracker for logging #8106

karthiknadig opened this issue Oct 18, 2019 · 4 comments
Assignees
Labels
area-debugging feature-request Request for new features or functionality

Comments

@karthiknadig
Copy link
Member

When we switch to the thew debug adapter we will loose extension side logging for the DAP. Since it currently sits in the type script debug adapter. We should be using DebugAdapterTracker for logging to ensure we can capture logs in all debug sessions attach or launch.

@ericsnowcurrently
Copy link
Member

@karthiknadig, how to validate?

@karthiknadig
Copy link
Member Author

Ensure you are in debug adapter descriptor experiment. Ensure ‘logToFile’:true is set in launch json. Then just debug any python script.

@karthiknadig
Copy link
Member Author

Oh and the result would be a .log file in the python extension directory.

@ericsnowcurrently ericsnowcurrently removed their assignment Nov 6, 2019
@ericsnowcurrently
Copy link
Member

I was able to verify that (on master) the log file (2 actually) is created when I put myself in the experiment and add that setting to my launch config. I also verified that logs are no longer created after I remove that setting.

@ghost ghost removed the needs PR label Nov 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-debugging feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants