Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add play button for all users #7423

Closed
luabud opened this issue Sep 16, 2019 · 3 comments
Closed

Add play button for all users #7423

luabud opened this issue Sep 16, 2019 · 3 comments
Assignees
Labels
area-terminal feature-request Request for new features or functionality

Comments

@luabud
Copy link
Member

luabud commented Sep 16, 2019

Stop experiment for play button and ship it to all users :)

We should hide the button if the code runner extension is enabled. Also, we could use these icons:

https://github.com/microsoft/vscode-icons/blob/master/icons/light/run.svg
https://github.com/microsoft/vscode-icons/blob/master/icons/dark/run.svg

@luabud luabud added feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team needs PR labels Sep 16, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 16, 2019
@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Sep 16, 2019

Prescribed Solution

@luabud
Copy link
Member Author

luabud commented Sep 25, 2019

Actually these are the exact same icons that are being used by the code runner extension. Let's use this one instead then:
https://github.com/microsoft/vscode-icons/blob/master/icons/dark/start.svg
https://github.com/microsoft/vscode-icons/blob/master/icons/light/start.svg

These are also closer to the icon we A/B tested it. It's basically the same icon but "hollowed" (to conform with the new icons in VS Code)

@ericsnowcurrently
Copy link
Member

This seems to be working using the latest insiders. The output panel says that I'm in the experiment, but I cannot tell if I'm in the old experiment or just by default (the new status quo). My local experiments.json certainly reflects "everyone is in the experiment now", so I guess this is okay.

@ghost ghost removed the needs PR label Sep 30, 2019
@ericsnowcurrently ericsnowcurrently removed their assignment Sep 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants