-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add play button for all users #7423
Comments
Prescribed Solution
|
Actually these are the exact same icons that are being used by the code runner extension. Let's use this one instead then: These are also closer to the icon we A/B tested it. It's basically the same icon but "hollowed" (to conform with the new icons in VS Code) |
This seems to be working using the latest insiders. The output panel says that I'm in the experiment, but I cannot tell if I'm in the old experiment or just by default (the new status quo). My local experiments.json certainly reflects "everyone is in the experiment now", so I guess this is okay. |
Stop experiment for play button and ship it to all users :)
We should hide the button if the code runner extension is enabled. Also, we could use these icons:
https://github.com/microsoft/vscode-icons/blob/master/icons/light/run.svg
https://github.com/microsoft/vscode-icons/blob/master/icons/dark/run.svg
The text was updated successfully, but these errors were encountered: