Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix A/B testing sampling #7218

Closed
luabud opened this issue Sep 5, 2019 · 1 comment
Closed

Fix A/B testing sampling #7218

luabud opened this issue Sep 5, 2019 · 1 comment
Assignees
@karrtikr @luabud
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone
2019 October Spri...

Comments

@luabud
Copy link
Member

luabud commented Sep 5, 2019 •
edited
Loading

Prescribed solution:

  • Use FNV instead of SHA512 for the hash
  • Consider adding tests to make sure distribution is uniform (e.g. how many hits each buckets has)
@luabud luabud added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team feature-* labels Sep 5, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 5, 2019
@luabud luabud added this to the September sprint 2019.1 milestone Sep 5, 2019
@luabud luabud added unplanned important Issue identified as high-priority labels Sep 5, 2019
@karrtikr karrtikr self-assigned this Sep 5, 2019
@karrtikr karrtikr mentioned this issue Sep 6, 2019
Merged
8 tasks
@luabud
Copy link
Member Author

luabud commented Oct 22, 2019

Validated 👍

@luabud luabud closed this as completed Oct 22, 2019
@ghost ghost removed the needs PR label Oct 22, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

@luabud luabud

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Milestone
2019 October Sprint 2
Development

No branches or pull requests
4 participants
@brettcannon @karthiknadig @karrtikr @luabud