Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ptvsd typo in descriptions #7097

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Fix ptvsd typo in descriptions #7097

merged 2 commits into from
Aug 26, 2019

Conversation

biozz
Copy link

@biozz biozz commented Aug 25, 2019

There was an annoying typo in the description of the attach configuration: ptsvd -> ptvsd.

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

There was an annoying typo in the description of the attach configuration: `ptsvd` -> `ptvsd`
@msftclas
Copy link

msftclas commented Aug 25, 2019

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

Codecov Report

Merging #7097 into master will decrease coverage by 57.67%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #7097       +/-   ##
==========================================
- Coverage   57.67%      0%   -57.68%     
==========================================
  Files         483      56      -427     
  Lines       21025     529    -20496     
  Branches     3446      64     -3382     
==========================================
- Hits        12127       0    -12127     
+ Misses       8124     529     -7595     
+ Partials      774       0      -774
Impacted Files Coverage Δ
src/client/common/installer/serviceRegistry.ts 0% <0%> (-100%) ⬇️
...lient/datascience/jupyter/jupyterSelfCertsError.ts 0% <0%> (-100%) ⬇️
src/client/debugger/extension/serviceRegistry.ts 0% <0%> (-100%) ⬇️
src/client/common/serviceRegistry.ts 0% <0%> (-100%) ⬇️
src/client/interpreter/locators/services/conda.ts 0% <0%> (-100%) ⬇️
src/client/common/utils/regexp.ts 0% <0%> (-100%) ⬇️
src/client/common/utils/icons.ts 0% <0%> (-100%) ⬇️
src/client/debugger/constants.ts 0% <0%> (-100%) ⬇️
src/client/interpreter/serviceRegistry.ts 0% <0%> (-100%) ⬇️
src/client/linters/serviceRegistry.ts 0% <0%> (-100%) ⬇️
... and 451 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4e7c0...90fec6b. Read the comment docs.

@kimadeline kimadeline merged commit 1f3846f into microsoft:master Aug 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants