Add a "play" button to run python file in terminal

[luabud]

It'd be nice to add that at the top right (on the editor groups)

[DonJayamanne]

We might instead want to contribute to existing extension.

[brettcannon]

Provide a setting to hide the button (on by default).

[ericsnowcurrently]

@qubitron, it sounds like you want to experiment with different icons. Would you mind noting here what you have in mind?

[karrtikr]

validated

[qubitron]

/cc @luabud not sure if I would consider this closed until we make this available to 100% of users!

[joeparis]

Provide a setting to hide the button (on by default).

I would very much like to have the option to hide the provided "Run Python File in Terminal" button. I have the Code Runner extension installed as it provides a similar capability for many languages and I now have two such buttons in the tab group whenever I have a Python file open.

[ericsnowcurrently]

@joeparis, please create a new issue (enhancement request) for that. I'll create one as soon as I can if you don't beat me to it, but it may be more correct if you do it. :)

[joeparis]

@joeparis, please create a new issue (enhancement request) for that. I'll create one as soon as I can if you don't beat me to it, but it may be more correct if you do it. :)

@ericsnowcurrently Done, issue #7034. Thanks!!

And immediately closed as a duplicate of #6921

[yzhang-gh]

I saw this in the 2019.8.0 (6 August 2019) release notes but didn't see the "play" button. 🤔

(I am using version 2019.8.30787 (13 August 2019))

[ericsnowcurrently]

@joeparis, yeah, sorry, I didn't notice it was a duplicate.

[brettcannon]

@yzhang-gh we're A/B testing this feature, so if you didn't fall into the experiment group you won't see the button.

[yzhang-gh]

@brettcannon Thanks for the clarification. I would suggest making a separate "experimental features" section in the release notes. It is a bit confusing.

[luabud]

We still need to add a setting to disable the button

[DonJayamanne]

We still need to add a setting to disable the button

Why?

[karrtikr]

@DonJayamanne Here #6921

[DonJayamanne]

What about the comment here #6921 (comment) ?

@luabud @karrtikr /cc
I prefer and have always pushed for the same solution that had been suggested by @qubitron.
Adding a setting seems unnecessary. I.e. if we detect the coderunner extension is installed why can't we just hide the button, less settings, less documentation... Etc..
Raising this as I'm not convinced @quibtron comment has been taken into account.

[karrtikr]

@DonJayamanne I agree.

[qubitron]

The feedback from users was to have a setting to hide the play button, so it's clear we don't need to be any fancier than that. Before we hide our button, we first need to contribute to the code runner extension to fix it so that they use the correct python path. Either way some action is needed before we can finish this work in the next sprint.

[DonJayamanne]

we first need to contribute to the code runner extension to fix it so that they use the correct python path

This should fix the problem. Along with automatically hiding out button. We just need to decide on an approach.

[luabud]

For now I'm proposing that we hide this button if the code runner extension is enabled. Also, we could use these icons:

https://github.com/microsoft/vscode-icons/blob/master/icons/light/play.svg
https://github.com/microsoft/vscode-icons/blob/master/icons/dark/play.svg

[luabud]

Closing as this has been shipped in version 2019.10.41019.