Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test explorer - beaker icon should be hidden when tests are disabled #4494

Closed
luabud opened this issue Feb 21, 2019 · 1 comment
Closed

Test explorer - beaker icon should be hidden when tests are disabled #4494

luabud opened this issue Feb 21, 2019 · 1 comment
Assignees
@DonJayamanne @karrtikr
Labels
area-testing bug Issue identified by VS Code Team member as probable bug
Milestone
2019, week 9 - Fe...

Comments

@luabud
Copy link
Member

luabud commented Feb 21, 2019

If tests are disable (by clicking on the button "Disable tests" that appears on the prompt or explicitly setting "python.unitTest.promptToConfigure": false), I think it'd be expected to hide the beaker icon from the activity bar view.
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Feb 21, 2019
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR area-testing labels Feb 25, 2019
@ghost ghost removed triage-needed Needs assignment to the proper sub-team labels Feb 25, 2019
@DonJayamanne
Copy link

DonJayamanne commented Feb 27, 2019 •
edited
Loading

When we disable tests in disableTests of https://github.com/Microsoft/vscode-python/blob/37d6818e41d5065ec9dd39d474186873645c319d/src/client/unittests/display/main.ts invoke the following code: this.commandManager.executeCommand('setContext', 'testsDiscovered', false)

Optionally utilize src/client/unittests/common/services/contextService.ts

@karrtikr karrtikr mentioned this issue Mar 5, 2019
Merged
9 tasks
@DonJayamanne DonJayamanne self-assigned this Mar 11, 2019
@ghost ghost removed the needs PR label Mar 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

@karrtikr karrtikr

Labels
area-testing bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
2019, week 9 - Feb Sprint 5
Development

No branches or pull requests
3 participants
@DonJayamanne @karrtikr @luabud