Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify and install Python dependencies in a requirements.txt file #2965

Closed
brettcannon opened this issue Oct 20, 2018 · 5 comments
Closed
Assignees
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@brettcannon
Copy link
Member

brettcannon commented Oct 20, 2018

Right now we have some Python source code checked into our repository. We should move away from that and over to pinned versions that we install via pip.

The install command should be:

python -m pip install --target pythonFiles --implementation py --no-deps -r requirements.txt

The requirements.txt files should be:

# Needs 'futures' for Python 2; see https://github.com/Microsoft/vscode-python/issues/2022 .
isort==4.3.4
parso==0.2.1
jedi==0.12.0
# Should probably start pinning ptvsd.
ptvsd

And with that we can drop almost all of the third-party code in pythonFiles that we have checked into our repo. This will require updating where we install ptvsd, though, as well as probably renaming/moving the requirements.txt file we already have in the top-level directory that specifies requirements for tests.

@DonJayamanne
Copy link

DonJayamanne commented Oct 20, 2018

Should probably start pinning ptvsd.

However for CI testing purposes, I'd like to ensure we have the latest Master branch of PTVSD.

@Brcrwilliams

This comment has been minimized.

@DonJayamanne

This comment has been minimized.

@brettcannon
Copy link
Member Author

@DonJayamanne I knew you were going to say that 😉 . That's fine, but for general development and especially for building the extension we shouldn't do that.

@brettcannon brettcannon added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Oct 22, 2018
@DonJayamanne
Copy link

Just wanted to ensure we do not forget about that requirement (for testing purposes), either way, I do agree with the suggestion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

3 participants