Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pre-commit hooks and move linters to CI #2963

Closed
DonJayamanne opened this issue Oct 19, 2018 · 2 comments
Closed

Remove pre-commit hooks and move linters to CI #2963

DonJayamanne opened this issue Oct 19, 2018 · 2 comments
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

  • Ensure modified files are compiled using the strict flag in TSC
  • Ensure new files contain the copyright + use strict header
  • Ensure all calls to showInformation... messages make use of localized strings.
This was referenced Oct 19, 2018
Closed
Merged
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Oct 22, 2018
@DonJayamanne DonJayamanne mentioned this issue Nov 7, 2018
Merged
2 tasks
DonJayamanne added a commit that referenced this issue Nov 8, 2018
@DonJayamanne
Remove pre commit hook and disabled mandating copyright headers (#3243)
e370a3b 
For #2963
@d3r3kk
Copy link

d3r3kk commented Dec 10, 2018

Is this done @DonJayamanne?

@DonJayamanne
Copy link
Author

Done

@lock lock bot locked as resolved and limited conversation to collaborators Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonJayamanne @d3r3kk