Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic smoke tests that ensure ensures language server downloads and runs #2041

Closed
brettcannon opened this issue Jun 21, 2018 · 3 comments
Closed

Add basic smoke tests that ensure ensures language server downloads and runs #2041

brettcannon opened this issue Jun 21, 2018 · 3 comments
Assignees
@DonJayamanne
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Milestone
2018, week 44 - N...

Comments

@brettcannon
Copy link
Member

Need to make sure we don't regress in terms of basic smoke tests and the integration side from the extension to calling the language server itself.
@brettcannon brettcannon added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Jun 21, 2018
@brettcannon brettcannon added this to the Jul 2018 milestone Jun 21, 2018
@brettcannon brettcannon added the P0 label Jun 21, 2018
@DonJayamanne
Copy link

Hopefully we can reuse something that VS Code team is putting together - #2024

@brettcannon brettcannon added important Issue identified as high-priority and removed P0 labels Jul 11, 2018
@brettcannon brettcannon removed this from the Jul 2018 milestone Jul 11, 2018
@d3r3kk
Copy link

d3r3kk commented Aug 22, 2018

@brettcannon @DonJayamanne : Is there something for me to do here?

@brettcannon
Copy link
Member Author

At this point probably not because we will simply have to make sure we test with the version of the language server we ship with.

@DonJayamanne DonJayamanne mentioned this issue Oct 2, 2018
Closed
@qubitron qubitron changed the title Test the language server in VSTS Add basic smoke tests that ensure ensures language server downloads and runs Oct 31, 2018
@d3r3kk d3r3kk self-assigned this Nov 3, 2018
@DonJayamanne DonJayamanne assigned DonJayamanne and unassigned d3r3kk Nov 7, 2018
@DonJayamanne DonJayamanne mentioned this issue Nov 7, 2018
Merged
4 tasks
DonJayamanne added a commit that referenced this issue Nov 8, 2018
@DonJayamanne
Refactor language server tests and add tests for language server (#3231)
92de223 
For #2041
@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority
Projects
None yet
Milestone
2018, week 44 - Nov sprint 1
Development

No branches or pull requests
3 participants
@brettcannon @DonJayamanne @d3r3kk