Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure python.pythonPath is set for LSP configuration/workspace call #11083

Closed
Tracked by #11015
jakebailey opened this issue Apr 10, 2020 · 1 comment
Closed
Tracked by #11015

Ensure python.pythonPath is set for LSP configuration/workspace call #11083

jakebailey opened this issue Apr 10, 2020 · 1 comment
Labels
area-environments Features relating to handling interpreter environments area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality

Comments

@jakebailey
Copy link
Member

With python.pythonPath no longer always being set, a language server which queries for the user's configuration will no longer be able to see the currently active environment, as LSP only queries VS Code's view of the settings.json overlays.

To keep this call working, the old python.pythonPath setting can be added to the response to the workspace/configuration call, simulating the old behavior while keeping the value stored outside any settings.json.

Part of #11015.
@jakebailey jakebailey added feature-request Request for new features or functionality needs PR labels Apr 10, 2020
@jakebailey jakebailey mentioned this issue Apr 10, 2020
Merged
10 tasks
@karrtikr karrtikr added area-environments Features relating to handling interpreter environments area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. labels Apr 12, 2020
@karrtikr karrtikr mentioned this issue Apr 12, 2020
Closed
21 tasks
@jakebailey jakebailey mentioned this issue Jun 15, 2020
Merged
10 tasks
@jakebailey
Copy link
Member Author

This has been done for ages.

@ghost ghost removed the needs PR label Jan 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-environments Features relating to handling interpreter environments area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakebailey @karrtikr