Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save notebooks with ordered keys #2165

Closed
chrisjsewell opened this issue Mar 13, 2020 · 2 comments
Closed

Save notebooks with ordered keys #2165

chrisjsewell opened this issue Mar 13, 2020 · 2 comments

Comments

@chrisjsewell
Copy link

It would be ideal if the notebook JSON was saved with sorted top-level keys, i.e. ['cells', 'metadata', 'nbformat', 'nbformat_minor']. Currently the order is ['nbformat', 'nbformat_minor', 'metadata', 'cells'].

The reason for this is to reduce git diffs, if for example one also opens and saves the notebook via jupyter notebook or jupyter lab (which save it in this manner).

(as noted in https://github.com/microsoft/vscode-python/issues/10544#issuecomment-598752751)

@DavidKutu
Copy link

DavidKutu commented Mar 16, 2020

Good catch @chrisjsewell.

We'll get to it.

@rchiodo
Copy link
Contributor

rchiodo commented Apr 21, 2020

Validated.

@rchiodo rchiodo closed this as completed Apr 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
@microsoft microsoft unlocked this conversation Nov 13, 2020
@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-python Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants