Kernel interrupt indicates kernel crashed when it didn't

[jmew]

interrupting the kernel will cause the kernel to crash, which then loses the entire kernel context of previous execution

Repro steps in screenshot below.

[rchiodo]

This is by design. A kernel interrupt is throwing an exception. If the python code running doesn't handle it, it can cause the entire process to die.

Jupyter behaves this way too.

[jmew]

I apologize if im missing something,

But in Jupyter, the kernel doesnt get restarted if it is interrupted. The context remains. E.g. in the example below, the kernel maintains reference to the x=1 execution.

But in the interactive window, the context is lost (e.g. the kernel loses context that x=1 was run previously)

[rchiodo]

That's just luck. We do nothing different than jupyter does.

[rchiodo]

Actually I think we're showing the message even if there isn't a restart. The kernel didn't actually restart.

[rchiodo]

So the bug here is the message showing up, not the kernel restarting :)

[rchiodo]

Looking at the code, looks like there's a number of problems:

1. Restart handler in interruptKernel doesn't use the status from the restart handler (Should look like this)

            const restartHandler = (e: ServerStatus) => {
                if (e === ServerStatus.Restarting) {

1. When the interrupt finishes, the 'then' clause is indicating a restart. It should do nothing.

            // Start our interrupt. If it fails, indicate a restart
            this.session
                .interrupt(timeoutMs)
                .then(() => restarted.resolve([]))
                .catch(exc => {
                    traceWarning(`Error during interrupt: ${exc}`);
                    restarted.resolve([]);
                });

[greazer]

Not fixing this will cause customers to not trust the tool.

[IanMatthewHuff]

Validated. No more restart message when the kernel was interrupted.